[Android] Fix Shadow property affecting transform matrix. by Shalini-Ashokan · Pull Request #32962 · dotnet/maui

Shalini-Ashokan · 2025-12-02T14:54:10Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

When a Shadow property is applied to any visual element on Android (Border, Label, Image, etc.), transform properties (Scale, Rotation, Translation) do not work correctly.

Root Cause

When a view has a Shadow, Android wraps it in a container that draws the shadow. The problem was that transforms were applied to the content inside the container, so the content would scale/rotate but the shadow stayed in place.

Description of Change

Modified the initialization logic to detect when a view is wrapped in a container and apply transforms to the container instead. This ensures shadows transform together with their content, fixing the issue for all controls that support Shadow properties.

Validated the behavior in the following platforms

Android
Windows
iOS
Mac

Issues Fixed

Fixes #32731

Test case

The test case is included in this PR.

Output ScreenShot

Before	After
32731-Before-Fix.mov	32731-After-Fix.mov

Shalini-Ashokan · 2026-02-19T07:53:12Z

The test is already added in this PR. This PR test case covers all scenarios of the current issue also. The issues are the same but created PR for platform-specific. I manually ensured the test case. It is working fine. The AI concern is not valid because the test is not added due to the test case addition. Once this PR is merged, that test case covers both issues.

Shalini-Ashokan · 2026-03-30T13:28:25Z

🚦 Gate — Test Verification

📊 Expand Full Gate — 656a6da · modified the fix

The gate failed because the test was added in another PR, as mentioned in my previous comment

kubaflo · 2026-04-03T10:50:12Z

@Shalini-Ashokan could you please duplicate the test for this PR?

Copilot

Pull request overview

Fixes Android behavior where applying Shadow wraps the native view, causing transforms (scale/rotation/translation/anchor) to be applied to the inner view instead of the shadow-drawing wrapper.

Changes:

Transfer existing transform properties from the inner Android view to the WrapperView when the container is created (and back when removed).
Add an Android ResetTransform helper to clear transforms on the source view after transfer.
Update Android batched initialization to initialize the wrapper when a view is wrapped.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
`src/Core/src/Platform/Android/WrapperView.cs`	Transfers transform-related properties between inner view and wrapper on container add/remove.
`src/Core/src/Platform/Android/ViewExtensions.cs`	Adds `ResetTransform` helper used during transform transfer.
`src/Core/src/Handlers/View/ViewHandler.cs`	Adjusts Android batched initialization to target the wrapper when present.

Copilot · 2026-04-06T06:53:52Z

+				// If the view is wrapped in a WrapperView (for Shadow/Clip), apply batched properties to the wrapper instead.
+				var viewToInitialize = pv.Parent is WrapperView ? (PlatformView)pv.Parent : pv;
+				viewToInitialize.Initialize(view);
+			}
 		}


MapInitializeBatchedProperties now calls Initialize(view) on the WrapperView when the platform view is wrapped. Android.ViewExtensions.Initialize batches more than transforms (e.g., enabled, minimumHeight, minimumWidth, alpha), but later property updates (e.g., MapIsEnabled, MapMinimumHeight/Width) still target handler.PlatformView (the inner view). This can leave the wrapper and inner view out of sync (notably: if the view starts disabled and is later enabled, the wrapper may remain disabled and continue blocking input). Consider keeping Initialize(view) on the inner PlatformView and then transferring only the transform-related properties (translation/scale/rotation/pivot) to the wrapper (resetting the inner transforms), or otherwise ensure non-transform properties remain applied consistently to the inner view and/or are updated on the wrapper too.

Suggested change

// If the view is wrapped in a WrapperView (for Shadow/Clip), apply batched properties to the wrapper instead.

var viewToInitialize = pv.Parent is WrapperView ? (PlatformView)pv.Parent : pv;

viewToInitialize.Initialize(view);

}

}

pv.Initialize(view);

if (pv.Parent is WrapperView wrapper)

TransferBatchedTransformsToWrapper(pv, wrapper);

}

}

static void TransferBatchedTransformsToWrapper(PlatformView platformView, WrapperView wrapperView)

{

wrapperView.TranslationX = platformView.TranslationX;

wrapperView.TranslationY = platformView.TranslationY;

wrapperView.ScaleX = platformView.ScaleX;

wrapperView.ScaleY = platformView.ScaleY;

wrapperView.Rotation = platformView.Rotation;

wrapperView.RotationX = platformView.RotationX;

wrapperView.RotationY = platformView.RotationY;

wrapperView.PivotX = platformView.PivotX;

wrapperView.PivotY = platformView.PivotY;

platformView.TranslationX = 0;

platformView.TranslationY = 0;

platformView.ScaleX = 1;

platformView.ScaleY = 1;

platformView.Rotation = 0;

platformView.RotationX = 0;

platformView.RotationY = 0;

platformView.PivotX = 0;

platformView.PivotY = 0;

}

github-actions · 2026-04-07T07:56:55Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 32962

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 32962"

Shalini-Ashokan · 2026-04-07T09:48:48Z

@Shalini-Ashokan could you please duplicate the test for this PR?

@kubaflo, I have added the test cases and verified them.

kubaflo

One test failed

sheiksyedm · 2026-04-08T09:50:17Z

/azp run maui-pr-uitests

azure-pipelines · 2026-04-08T09:50:31Z

Azure Pipelines successfully started running 1 pipeline(s).

kubaflo

Could you please review: #32962 (comment)

Shalini-Ashokan · 2026-04-13T06:12:28Z

Could you please review: #32962 (comment)

@kubaflo, I addressed the AI concerns

dotnet-policy-service Bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Dec 2, 2025

sheiksyedm added area-animation Animation, Transitions, Transforms platform/android labels Dec 3, 2025

MauiBot added the s/agent-review-incomplete AI agent could not complete all phases (blocker, timeout, error) label Mar 28, 2026

sheiksyedm marked this pull request as ready for review April 6, 2026 06:46

Copilot AI review requested due to automatic review settings April 6, 2026 06:46

Copilot started reviewing on behalf of sheiksyedm April 6, 2026 06:47 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

github-actions Bot mentioned this pull request Apr 6, 2026

[repo-status] Daily Repo Status - April 6, 2026 🌟 #34826

Closed

build-analysis Bot mentioned this pull request Apr 7, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

build-analysis Bot mentioned this pull request Apr 7, 2026

[android-arm64] The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#6408

Closed

3 tasks

kubaflo requested changes Apr 7, 2026

View reviewed changes

Shalini-Ashokan added 7 commits April 9, 2026 10:57

Fixed the shadow issue

2e57bc2

Added test case and fixed the dynamic shadow add scenario

2224448

Removed test case

fee63d6

Modified the fix

029c45e

modified the fix

32143f8

modified the fix

db271d7

Added the test case

3a719cb

Shalini-Ashokan force-pushed the fix-32731 branch from 7638dc1 to 3a719cb Compare April 9, 2026 05:31

committed the failed test image

56c9d46

kubaflo requested changes Apr 9, 2026

View reviewed changes

Address the AI concerns

3541352

dotnet deleted a comment from MauiBot Apr 13, 2026

dotnet deleted a comment from rmarinho Apr 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] Fix Shadow property affecting transform matrix.#32962

[Android] Fix Shadow property affecting transform matrix.#32962
Shalini-Ashokan wants to merge 9 commits into
dotnet:mainfrom
Shalini-Ashokan:fix-32731

Shalini-Ashokan commented Dec 2, 2025

Uh oh!

Shalini-Ashokan commented Feb 19, 2026

Uh oh!

Shalini-Ashokan commented Mar 30, 2026

🚦 Gate — Test Verification

Uh oh!

kubaflo commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

github-actions Bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

Shalini-Ashokan commented Apr 7, 2026

Uh oh!

kubaflo left a comment

Uh oh!

sheiksyedm commented Apr 8, 2026

Uh oh!

azure-pipelines Bot commented Apr 8, 2026

Uh oh!

kubaflo left a comment

Uh oh!

Shalini-Ashokan commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

-				// If the view is wrapped in a WrapperView (for Shadow/Clip), apply batched properties to the wrapper instead.
-				var viewToInitialize = pv.Parent is WrapperView ? (PlatformView)pv.Parent : pv;
-				viewToInitialize.Initialize(view);
-			}
-		}
+				pv.Initialize(view);
+				if (pv.Parent is WrapperView wrapper)
+					TransferBatchedTransformsToWrapper(pv, wrapper);
+			}
+		}
+		static void TransferBatchedTransformsToWrapper(PlatformView platformView, WrapperView wrapperView)
+		{
+			wrapperView.TranslationX = platformView.TranslationX;
+			wrapperView.TranslationY = platformView.TranslationY;
+			wrapperView.ScaleX = platformView.ScaleX;
+			wrapperView.ScaleY = platformView.ScaleY;
+			wrapperView.Rotation = platformView.Rotation;
+			wrapperView.RotationX = platformView.RotationX;
+			wrapperView.RotationY = platformView.RotationY;
+			wrapperView.PivotX = platformView.PivotX;
+			wrapperView.PivotY = platformView.PivotY;
+			platformView.TranslationX = 0;
+			platformView.TranslationY = 0;
+			platformView.ScaleX = 1;
+			platformView.ScaleY = 1;
+			platformView.Rotation = 0;
+			platformView.RotationX = 0;
+			platformView.RotationY = 0;
+			platformView.PivotX = 0;
+			platformView.PivotY = 0;
+		}

Conversation

Shalini-Ashokan commented Dec 2, 2025

Issue Details

Root Cause

Description of Change

Issues Fixed

Test case

Output ScreenShot

Uh oh!

Shalini-Ashokan commented Feb 19, 2026

Uh oh!

Shalini-Ashokan commented Mar 30, 2026

🚦 Gate — Test Verification

Uh oh!

kubaflo commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shalini-Ashokan commented Apr 7, 2026

Uh oh!

kubaflo left a comment

Choose a reason for hiding this comment

Uh oh!

sheiksyedm commented Apr 8, 2026

Uh oh!

azure-pipelines Bot commented Apr 8, 2026

Uh oh!

kubaflo left a comment

Choose a reason for hiding this comment

Uh oh!

Shalini-Ashokan commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions Bot commented Apr 7, 2026 •

edited

Loading